The main objectives of the current study were to evaluate the potential effects of biochar derived from sugar cane bagasse (SC-BC) and orange peel (OP-BC) on improving the physicochemical properties of a metal smelter contaminated soil, and determining its potentiality for stabilizing Pb and As in soil. To achieve these goals, biochar was produced in a small-scale biochar producing plant, and an incubation experiment was conducted using a silt loam metal-contaminated soil treated with different application rates of biochar (0-10% w/w). The obtained results showed that, the addition of SC-BC and OP-BC increased significantly the soil aggregate stability, water-holding capacity, cation exchange capacity, organic matter and N-status in soil. SC-BC considerably decreased the solubility of Pb to values lower than the toxic regulatory level of the toxicity characteristics leaching procedure extraction (5mgL-1). The rise in soil pH caused by biochar application, and the increase of soil organic matter transformed the labile Pb into less available fractions i.e. "Fe-Mn oxides" and "organic" bound fractions. On the other hand, As was desorbed from Fe-Mn oxides, which resulted in greater mobility of As in the treated soil. We concluded that SC-BC and OP-BC could be used successfully for remediating soils highly contaminated with Pb. However, considerable attention should be paid when using it in soil contaminated with As.